Bump MSRV from 1.88.0 to 1.94.0#23632
Open
Jefffrey wants to merge 1 commit into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #23632 +/- ##
=======================================
Coverage ? 80.65%
=======================================
Files ? 1086
Lines ? 366097
Branches ? 366097
=======================================
Hits ? 295271
Misses ? 53233
Partials ? 17593 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Personally I'm okay with bumping MSRV more aggressively, but I don't know if we have a policy on it. |
neilconway
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
see previous bump
honestly my main motivation was i was using a feature from
1.89.0apparently for #23631 and realized we hadn't bumped this in a whileif we prefer to be more conservative with msrv bumps (i.e. only bump if a dependency requires it or we see a really useful feature/lib function in newer versions) then i'm fine with leaving it and altering my PR above, but in the past we usually kept up to date with bumping our msrv