Skip to content

Bump MSRV from 1.88.0 to 1.94.0#23632

Open
Jefffrey wants to merge 1 commit into
apache:mainfrom
Jefffrey:bump-msrv
Open

Bump MSRV from 1.88.0 to 1.94.0#23632
Jefffrey wants to merge 1 commit into
apache:mainfrom
Jefffrey:bump-msrv

Conversation

@Jefffrey

Copy link
Copy Markdown
Contributor

see previous bump

honestly my main motivation was i was using a feature from 1.89.0 apparently for #23631 and realized we hadn't bumped this in a while

if we prefer to be more conservative with msrv bumps (i.e. only bump if a dependency requires it or we see a really useful feature/lib function in newer versions) then i'm fine with leaving it and altering my PR above, but in the past we usually kept up to date with bumping our msrv

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jul 16, 2026
@Jefffrey Jefffrey added the api change Changes the API exposed to users of the crate label Jul 16, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@a287c0a). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #23632   +/-   ##
=======================================
  Coverage        ?   80.65%           
=======================================
  Files           ?     1086           
  Lines           ?   366097           
  Branches        ?   366097           
=======================================
  Hits            ?   295271           
  Misses          ?    53233           
  Partials        ?    17593           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@neilconway

Copy link
Copy Markdown
Contributor

Personally I'm okay with bumping MSRV more aggressively, but I don't know if we have a policy on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api change Changes the API exposed to users of the crate documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants