feat: memoize for FFI_PartitionEvaluator#22659
Open
sandugood wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FFI_PartitionEvaluatormissingmemoize#22336 .Rationale for this change
Before this change there was no reasonable
memoizefor theForeignPartitionEvaluatorWhat changes are included in this PR?
Added
memoizefunction pointer toFFI_PartitionEvaluatorstruct and implemented the FFI wrappermemoize_fn_wrapperthat serializes/deserializesWindowAggStateacross the boundaryImplemented
PartitionEvaluator::memoizeforForeignPartitionEvaluator, preservingwindow_frame_ctx(which cannot cross FFI) across the callAre these changes tested?
Yes, tested both state preservation with
test_memoize_state_preservationandwindow_frame_ctxpreservation withtest_memoize_preserves_window_frame_ctx. All of the other tests in the crate also passAre there any user-facing changes?
Yes, but only behavioral — no API changes.