fix: make PushDownLeafProjections work with unnest#22620
Open
pabadrubio wants to merge 1 commit into
Open
Conversation
github-actions
Bot
added
optimizer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #22615.
Rationale for this change
PushDownLeafProjectionsthrows an error when it tries to push down an expression through anUnnestnode. It also tries to push leaf projections incorrectly forUnnestnodes.What changes are included in this PR?
This PR makes PushDownLeafProjections never push down leaf expressions through Unnest nodes. This avoids the code in
try_push_into_inputsfrom calling:on an Unnest node, which doesn't work.
Changing that line is not enough, as even in that case the code in
try_push_into_inputsto decide when to push down a projection is not valid for Unnest nodes, as explained in #22615In this PR, I only want to make sure that the optimizer works for Unnest cases, but we could probably do better and allow leaf expressions push downs when the expression refer to a column that is not being unnested.
Are these changes tested?
Added unit tests and
.slttests for these cases.Are there any user-facing changes?
No