fix(benchmarks): correct TPC-H benchmark SQL#21615
Open
kumarUjjawal wants to merge 2 commits intoapache:mainfrom
Open
fix(benchmarks): correct TPC-H benchmark SQL#21615kumarUjjawal wants to merge 2 commits intoapache:mainfrom
kumarUjjawal wants to merge 2 commits intoapache:mainfrom
Conversation
Contributor
Author
|
cc @Omega359 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
TPC-H query 11 was using a fixed
0.0001threshold in the HAVING clause. Per the TPC-H spec, this value must be0.0001 / SF.This means the benchmark query is only correct for scale factor 1. For larger scale factors the filter becomes too
strict, and for smaller scale factors it becomes too loose.
There are also few benchmark queries using fixed end dates where the spec uses
date + interval. Those are equivalent but using intervals matches the TPC-H query definitions more closely.What changes are included in this PR?
tpch_sf10.bench.sh.default scale factor of 1.
date ranges.
scale-factor parsing, and invalid scale factors.
Are these changes tested?
Yes
Are there any user-facing changes?
TPC-H benchmark query 11 now returns correct results when the scale factor is not 1.