Skip to content

ci: disable symbol export on Windows verification #1486

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
timsaucer wants to merge 4 commits into
base: main
Choose a base branch
from
+5 −0
Open

ci: disable symbol export on Windows verification #1486

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c4b05ae
Set rust flags on windows release verification
timsaucer Apr 10, 2026
8b99f73
Forward flag to linker
timsaucer Apr 10, 2026
9879fc7
Switch to msvc rust toolchain
timsaucer Apr 10, 2026
038fe60
Revert "Switch to msvc rust toolchain"
timsaucer Apr 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .github/workflows/verify-release-candidate.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,11 @@ jobs:
version: "27.4"
repo-token: ${{ secrets.GITHUB_TOKEN }}

- name: Set RUSTFLAGS for Windows GNU linker
if: matrix.os == 'windows'
shell: bash
run: echo "RUSTFLAGS=-C link-arg=-Wl,--exclude-libs=ALL" >> "$GITHUB_ENV"
Copy link
Copy Markdown
Contributor

@alamb alamb Apr 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the title of this PR says it is setting the linker to msvc but this seems to actually to disable automatic symbol export

https://linux.die.net/man/1/ld

--exclude-libs lib,lib,...
Specifies a list of archive libraries from which symbols should not be automatically exported. The library names may be delimited by commas or colons. Specifying "--exclude-libs ALL" excludes symbols in all archive libraries from automatic export. This option is available only for the i386 PE targeted port of the linker and for ELF targeted ports. For i386 PE , symbols explicitly listed in a .def file are still exported, regardless of this option. For ELF targeted ports, symbols affected by this option will be treated as hidden.


- name: Run release candidate verification
shell: bash
run: ./dev/release/verify-release-candidate.sh "${{ inputs.version }}" "${{ inputs.rc_number }}"
Loading