-
Notifications
You must be signed in to change notification settings - Fork 340
feat: expose Comet version as spark.comet.version runtime config #5049
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
andygrove
merged 1 commit into
apache:main
from
andygrove:feat/comet-version-runtime-conf
Jul 30, 2026
+47
−1
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -166,6 +166,33 @@ CometNativeColumnarToRow | |
| +- CometNativeScan parquet [a#6] Batched: true, DataFilters: [isnotnull(a#6), (a#6 > 5)], Format: CometParquet, Location: InMemoryFileIndex(1 paths)[file:/tmp/test], PartitionFilters: [], PushedFilters: [IsNotNull(a), GreaterThan(a,5)], ReadSchema: struct<a:int> | ||
| ``` | ||
|
|
||
| ## Checking the Comet Version | ||
|
|
||
| When the Comet plugin is loaded, it exposes its build version as the Spark config | ||
| `spark.comet.version`. This can be queried at runtime from any supported language, for example: | ||
|
|
||
| ```scala | ||
| scala> spark.conf.get("spark.comet.version") | ||
| ``` | ||
|
|
||
| ```sql | ||
| SET spark.comet.version; | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I hardly can imagine scenarios for user to change comet version
Member
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
| ``` | ||
|
|
||
| The same value is available programmatically on the JVM classpath, along with additional build | ||
| metadata that is useful when reporting issues: | ||
|
|
||
| ```scala | ||
| scala> import org.apache.comet.{COMET_VERSION, COMET_BRANCH, COMET_REVISION} | ||
| scala> println(COMET_VERSION) | ||
| ``` | ||
|
|
||
| Comet also logs its version when the native library is initialized: | ||
|
|
||
| ```shell | ||
| INFO core/src/lib.rs: Comet native library version <version> initialized | ||
| ``` | ||
|
|
||
| ## Additional Configuration | ||
|
|
||
| Depending on your deployment mode you may also need to set the driver & executor class path(s) to | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would be nice to get an example output?