fix(scheduler): fix test job-completion polling - #2354
Merged
Merged
Conversation
NoahKusaba
changed the title
milenkovicm
approved these changes
Aug 25, 2026
milenkovicm
left a comment
milenkovicm
left a comment
Contributor
There was a problem hiding this comment.
thanks @NoahKusaba good catch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
The job-completion poll loop in
SchedulerTest::run_with_subscriberused_ => continue,which skips the
sleep(100)below the match. Once a job reports a non-terminal status theloop polls with no delay and spins a core until the job finishes.
await_completionandawait_completion_timeouthad the same bug and no callers.What changes are included in this PR?
run_with_subscriber: collapsed the innermatchinto the outerif letsonon-terminal statuses fall through to the sleep.
await_completionandawait_completion_timeout(no callers).We can also not delete the unused functions, but this is a very clear bug regardless.
Are there any user-facing changes?
No