[CXF-9227] Fix SecurityManager permission regressions introduced in 4…#3256
Merged
Conversation
reta
reviewed
Jun 27, 2026
reta
approved these changes
Jun 28, 2026
Contributor
Author
|
Thanks @reta ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
….1.7
Summary
Fixes three SecurityManager permission regressions introduced in CXF 4.1.7
that break deployments running under a tight SecurityManager policy (reported
by the WildFly team during their 4.1.6 → 4.1.7 upgrade CI checks).
Root Cause
Issue 1 —
NetPermission("getProxySelector")(introduced by #3154)ProxyFactory.getSystemProxy()callsProxySelector.getDefault()withoutdoPrivileged, forcing all callers including user deployments to hold thispermission.
Issues 2 & 3 —
RuntimePermission("org.apache.cxf.permission")andSocketPermission(introduced by #3157)Setting
ACCESS_EXTERNAL_SCHEMA=""onSchemaFactoryroutes all schemaresolution through
SchemaLSResourceResolver→ExtendedURIResolver→URIResolver.tryFileSystem()— a code path never previously reached in thiscontext under a SecurityManager. This exposed two pre-existing gaps:
SecurityActions.fileExists()calledsm.checkPermission()outsidedoPrivileged, walking the full call stack into user deployment code.URIResolver.createInputStream()calledurl.openConnection()withoutdoPrivileged, requiring callers to holdSocketPermission.Fix
ProxyFactory.javaProxySelector.getDefault()indoPrivilegedSecurityActions.javasm.checkPermission()inside thedoPrivilegedblock so the stack walk stops at the CXF privilege boundary (confused-deputy guard preserved)URIResolver.javaurl.openConnection()indoPrivileged