GH-1084: Honor dontUseContainerParents for checkExists and namespace mkdir - #1301
Open
arimu1 wants to merge 1 commit into
Open
GH-1084: Honor dontUseContainerParents for checkExists and namespace mkdir#1301arimu1 wants to merge 1 commit into
arimu1 wants to merge 1 commit into
Conversation
…space mkdir Fixes apache#1084.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
checkExists().creatingParentContainersIfNeeded()ignoredCuratorFrameworkFactory.dontUseContainerParents()/useContainerParentsIfAvailable. Parents were always created asCreateMode.CONTAINER, which raisesUnimplementedon servers without container support (ZooKeeper 3.4.x, ClickHouse Keeper, etc.).CreateBuilderImpl.creatingParentContainersIfNeeded()already gates container parents on that flag and still creates ordinary persistent parents when it is off.ExistsBuilderImplnow does the same. Foreground and backgroundmkdirsalso re-check the flag so the asyncExistsBuilderImplconstructor path cannot send container creates either.NamespaceImpl.fixForNamespace()had the same hole:ZKPaths.mkdirs(..., asContainers = true)was hardcoded, so the first namespaced operation issued createContainer (opcode 19) even afterdontUseContainerParents(). That argument now usesclient.useContainerParentsIfAvailable().Fixes #1084 (CURATOR-565).
Closed prior attempts #352 / #353 / #354 only flipped the exists setter and did not fall back to persistent parents or cover namespace mkdir.
Tests
TestFramework.testExistsOverrideCreateParentContainers—dontUseContainerParents()+checkExists().creatingParentContainersIfNeeded(); parents remain after the leaf is deleted (would be auto-removed if they were containers).TestFramework.testNamespaceOverrideCreateParentContainers— namespaced client withdontUseContainerParents(); the namespace znode remains after its child is deleted.Local: Temurin 21,
mvn -pl curator-framework -am test -Dtest=TestFramework— 50/50 pass. The two new tests failed on unfixedmaster(assertNotNullafter container cleanup).