Skip to content

Clouseau: Separate write folders for each instance #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
poor-a wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Clouseau: Separate write folders for each instance #6059

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
639635f
Separate write folders for each clouseau instance
poor-a Jul 2, 2026
a009d77
Revert accidentally added changes
poor-a Jul 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions dev/run
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -631,18 +631,27 @@ config: [
name: clouseau1
domain: 127.0.0.1
}
clouseau: {
dir: dev/lib/node1/indexes

@rnewson rnewson Jul 2, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gabor's point aside for a moment, this path needs to use the ctx["devdir"] variable rather than assume 'dev/'

@pgj pgj Jul 2, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. On top of that, if we wanted to regenerate the configuration file for the sake of stay in sync with the contents of ctx["devdir"] that could easily overwrite the local changes. The purpose of this template is to lay down the configuration file if it does not exist, not to always keep that updated. This also showcases that ad-hoc overrides via Java properties are better suited for this scenario.

}
}
{
node: {
name: clouseau2
domain: 127.0.0.1
}
clouseau: {
dir: dev/lib/node2/indexes
}
}
{
node: {
name: clouseau3
domain: 127.0.0.1
}
clouseau: {
dir: dev/lib/node3/indexes
}
}
]
"""
Expand Down