Skip static methods in FluentPropertyBeanIntrospector and mapped lookup - #437
Merged
Merged
Conversation
Member
|
@rootvector2 merged 🚀 Thank you. |
garydgregory
added a commit
that referenced
this pull request
Aug 23, 2026
garydgregory
added a commit
that referenced
this pull request
Aug 23, 2026
Add missing unit tests that could have been in PR #437. The tests explicitly cover the mixed static/instance accessor cases that were missing: Mapped property with a static getter but instance setter: read method is ignored, write method is used. Mapped property with an instance getter but static setter: read method is used, write method is ignored. Fluent introspector with a static and an instance setter for the same property name: the instance setter is chosen and the property remains writable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FluentPropertyBeanIntrospector.introspectturns every public method whose name starts with the write prefix into a write method without checkingModifier.isStatic, andMappedPropertyDescriptor.getMethodaccepts the static methodsgetMatchingAccessibleMethodreturns (unlike its siblinginternalGetMethod, which already skips them), so once the fluent introspector is registeredBeanUtils.setProperty(form, "locale.default", "fr-FR")on any bean with aLocalegetter invokes the staticLocale.setDefaultand any public staticsetX(T)orgetX(String)/setX(String, T)reachable through a nested property becomes writable from apopulatemap; found while auditing the introspectors against the JavaBeans rulejava.beans.Introspectorfollows (static methods are never accessors), fixed by skipping static methods at both lookup sites, with regression tests inFluentPropertyBeanIntrospectorTestandMappedPropertyTestthat fail without the runtime change.mvn; that'smvnon the command line by itself.