Suppress class and declaringClass pseudo-properties in BeanMap#412
Merged
Conversation
BeanMap.initialize introspected the bean directly and registered the
class/declaringClass pseudo-properties, so BeanMap.get("class") returned
the bean's class loader that PropertyUtilsBean suppresses by default. Skip
both names during initialization.
garydgregory
changed the title
garydgregory
requested changes
Jul 11, 2026
garydgregory
left a comment
garydgregory
left a comment
Member
There was a problem hiding this comment.
Hi @rootvector2
Please my see my comments.
| public Object[] getSampleValues() { | ||
| final Object[] values = { Integer.valueOf(1234), Long.valueOf(1298341928234L), Double.valueOf(123423.34), Float.valueOf(1213332.12f), | ||
| Short.valueOf((short) 134), Byte.valueOf((byte) 10), Character.valueOf('a'), Integer.valueOf(1432), "SomeStringValue", objectInFullMap, | ||
| BeanWithProperties.class, }; |
Member
There was a problem hiding this comment.
Why was BeanWithProperties removed here?
Contributor
Author
There was a problem hiding this comment.
getSampleValues() is index-aligned with getSampleKeys() in AbstractMapTest; BeanWithProperties.class was the sample value for the class key, so removing the key means removing its value too, otherwise the arrays go out of sync.
| assertNull(map.get("class")); | ||
| assertNull(map.getReadMethod("class")); | ||
|
|
||
| final BeanMap enumMap = new BeanMap(java.time.DayOfWeek.MONDAY); |
Member
There was a problem hiding this comment.
Don't use a fully-qualified class name here.
Contributor
Author
There was a problem hiding this comment.
done, switched to an import of DayOfWeek.
garydgregory
added a commit
that referenced
this pull request
Jul 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BeanMap.initializeintrospects the bean withjava.beans.Introspectordirectly and registers every property descriptor, so theclasspseudo-property (Object.getClass, present on every bean) anddeclaringClass(Enum.getDeclaringClass, on enums) become map entries.PropertyUtilsBeanregistersSuppressPropertiesBeanIntrospector.SUPPRESS_CLASS/SUPPRESS_DECLARING_CLASSby default to drop exactly these, butBeanMapapplies no suppression, sonew BeanMap(bean).get("class")hands back the bean'sClassand its class loader, andkeySet()/entrySet()enumerate that entry to any caller treating theBeanMapas an opaqueMap. Skip both names ininitialize(), matching the"class".equals(name)guard already inBeanUtilsBean.copyProperties.Found while auditing which introspection paths honor the default
classsuppression;BeanMapwas the one that reintroduces it.BeanMapTest.testClassPropertyNotExposedfails without the runtime change. Updated the sample key/value arrays that pinned theclassentry.mvn; that'smvnon the command line by itself.