test: fix smoke test failures on xen/vmware#13628
Conversation
boring-cyborg
Bot
added
component:integration-test
Python
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with no SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Pull request overview
This PR targets integration smoke test stability across hypervisors (notably XenServer/XCP-ng and VMware) by skipping KVM-specific checks/tests when not running on KVM, and by adjusting a few timing/host prerequisite assumptions that can cause intermittent failures.
Changes:
- Skip KVM-only paths in smoke tests when the detected hypervisor is not KVM.
- Add additional host-tool prerequisite checks for a VPC source NAT IP update test.
- Add delays around affinity-group migration steps and make the events-resource test more tolerant around volume attach/detach operations.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| test/integration/smoke/test_nonstrict_affinity_group.py | Adds waits before migration steps in non-strict affinity group tests. |
| test/integration/smoke/test_network_extension_namespace.py | Skips KVM prerequisite checks on non-KVM hypervisors; expands required host tools for one test. |
| test/integration/smoke/test_kms_lifecycle.py | Skips a VM root-disk encryption test on non-KVM hypervisors. |
| test/integration/smoke/test_events_resource.py | Wraps volume attach/detach operations to avoid hard failures in some environments. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| try: | ||
| virtual_machine.attach_volume( | ||
| self.apiclient, | ||
| volume | ||
| ) |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13628 +/- ##
============================================
- Coverage 19.65% 19.64% -0.01%
+ Complexity 19792 19790 -2
============================================
Files 6368 6368
Lines 575107 575107
Branches 70370 70370
============================================
- Hits 113016 112987 -29
- Misses 449808 449846 +38
+ Partials 12283 12274 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 18593 |
|
@blueorangutan test ubuntu26 xcpng82 keepEnv |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + xcpng82) has been kicked to run smoke tests |
|
@blueorangutan test ubuntu26 vmware-80u3e keepEnv |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu26 mgmt + vmware-80u3e) has been kicked to run smoke tests |
Description
This PR fixes some smoke test failures on vmware or xenserver/xcpng
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?