Open
Conversation
| } | ||
| hostResponse.setHostType(host.getType()); | ||
| hostResponse.setLastPinged(new Date(host.getLastPinged())); | ||
| hostResponse.setLastPinged(new Date(host.getLastPinged() << 10)); |
Contributor
There was a problem hiding this comment.
Suggested change
| hostResponse.setLastPinged(new Date(host.getLastPinged() << 10)); | |
| hostResponse.setLastPinged(new Date(host.getLastPinged() * 1000)); |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #13030 +/- ##
============================================
- Coverage 16.26% 16.26% -0.01%
- Complexity 13433 13434 +1
============================================
Files 5665 5665
Lines 500530 500530
Branches 60787 60787
============================================
- Hits 81411 81410 -1
- Misses 410027 410028 +1
Partials 9092 9092
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes the lastpinged field in listHosts API responses by correctly converting the stored last_ping value into an epoch-milliseconds Date, so the returned timestamp reflects the actual last agent connection time instead of a near-1970 value.
Changes:
- Convert
HostJoinVO.lastPingedfrom the stored compact time unit (System.currentTimeMillis() >> 10) back to epoch milliseconds (<< 10) when populatingHostResponse.lastPinged.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the
lastpingedin host response.(note it shows the last time that the agent connected to management server, not the agent heartbeat time)
prior to the change
with the change (another environment)
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?