NPE correction when informing removed project in the 'listProjectRoles'#13022
Open
Tonitzpp wants to merge 1 commit intoapache:mainfrom
Open
NPE correction when informing removed project in the 'listProjectRoles'#13022Tonitzpp wants to merge 1 commit intoapache:mainfrom
Tonitzpp wants to merge 1 commit intoapache:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #13022 +/- ##
============================================
- Coverage 18.02% 17.94% -0.08%
- Complexity 16450 16499 +49
============================================
Files 5968 6019 +51
Lines 537086 540750 +3664
Branches 65961 66255 +294
============================================
+ Hits 96820 97061 +241
- Misses 429346 432749 +3403
- Partials 10920 10940 +20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, when using the
listProjectRolesAPI, passing theprojectidparameter of a removed project results in an NPE. This PR changes this behavior to return the messageFailed to find project by IDinstead.Types of changes
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
Before the changes
After the changes
How Has This Been Tested?
To perform the tests, a test project was created along with a project role. The project was deleted and the
listProjectRolesAPI was called passing the ID of the project role. This showed the new message.