Prefer destroy over delete volume for expunging

[bddvlpr]

Adapting the disk resource according to the instance standard as it also uses destroy. This destroys the disk but (optionally) leaves it unexpunged for manual cleanup or satefy measures.

Acceptance tests pass, also tested on an actual setup.

[Copilot]

🟡 Changes recommended

Add acceptance coverage verifying that unset or false expunge leaves the destroyed volume available for manual cleanup.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Updates cloudstack_disk to use CloudStack’s destroy API with optional volume expunging, consistent with instance behavior.

Changes:

• Adds the expunge argument, defaulting to false.
• Replaces DeleteVolume with conditional destruction and expunging.
• Updates documentation and acceptance configurations.

File summaries

File	Summary
website/docs/r/disk.html.markdown	Documents the expunge argument.
cloudstack/resource_cloudstack_disk.go	Implements configurable volume destruction.
cloudstack/resource_cloudstack_disk_test.go	Updates tests; a nit requests coverage for the default expunge = false behavior.

Review details

• Files reviewed: 3/3 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.