Skip to content

Fix greenplum_path.sh GPHOME resolution under relative symlinks #1765

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gfphoenix78 wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −6
Open

Fix greenplum_path.sh GPHOME resolution under relative symlinks #1765

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions gpMgmt/bin/generate-cloudberry-env.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,13 +17,15 @@ fi
if test -z "$SCRIPT_PATH"; then
echo "The shell cannot be identified. \$GPHOME may not be set correctly." >&2
fi
SCRIPT_DIR="$(cd "$(dirname "${SCRIPT_PATH}")" >/dev/null 2>&1 && pwd)"

if [ ! -L "${SCRIPT_DIR}" ]; then
GPHOME=${SCRIPT_DIR}
else
GPHOME=$(readlink "${SCRIPT_DIR}")
fi
# downstream PATH / PYTHONPATH / LD_LIBRARY_PATH derivations stay valid
# even when GPHOME is reached via a symlink whose target is a relative
# path (e.g. /opt/database -> database-2.1.0). `pwd -P` resolves every
# symlink component, returning the physical absolute path. This replaces
# an earlier branch that ran bare `readlink` on the script's directory,
# which would return the symlink target verbatim and break with relative
# targets (PYTHONPATH became relative, gppylib import failed).
GPHOME="$(cd "$(dirname "${SCRIPT_PATH}")" >/dev/null 2>&1 && pwd -P)"
EOF

cat <<"EOF"
Expand Down
Loading