CAMEL-24071: camel-spring-rabbitmq - Trim queue names and reject multi-queue polling#24741
Merged
Conversation
…i-queue polling Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Claus Ibsen <claus.ibsen@gmail.com>
gnodet
approved these changes
Jul 15, 2026
gnodet
left a comment
gnodet
left a comment
Contributor
There was a problem hiding this comment.
Clean, focused hardening of the RabbitMQ queue-name handling — LGTM.
What the PR does
-
DefaultListenerContainerFactory: trims each queue name after splitting on comma, so"q1, q2"works correctly instead of passing" q2"with leading whitespace tosetQueueNames. -
SpringRabbitPollingConsumer:- Trims the single queue name before calling
template.receive(queue). - Adds fail-fast validation in
doInit()— rejects multi-queue configs (queues=q1,q2) becauseRabbitTemplate.receive()only accepts a single queue name. Without this guard, the raw comma-separated string would be passed as a queue name, failing silently or producing unexpected behavior.
- Trims the single queue name before calling
-
Tests: Two new tests verify both the trimming behavior and the multi-queue rejection with a clear error message.
Checklist
- Tests — two new tests cover both changes
- Commit convention — JIRA key in title
- No public API break — internal factory / consumer behavior
- No security concerns
- CI — pending (just submitted)
Static analysis
ast-grep (only tool available) flagged a pre-existing broad catch (Exception e) in SpringRabbitPollingConsumer.receive() — not introduced by this PR.
Reviewed with Claude on behalf of gnodet. This review was generated by an AI agent and may contain inaccuracies; please verify all suggestions before applying.
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
🔬 Scalpel shadow comparison — Scalpel: 9 tested, 29 compile-only — current: 9 all testedMaveniverse Scalpel detected 38 affected modules (current approach: 9).
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Claude Code on behalf of davsclaus
split(",")on thequeuesoption now trims each entry, consistent withdeclareElements(). Previouslyqueues=q1, q2would make the listener subscribe to" q2"(leading space) while declaring"q2"— causing a mismatch at runtime.doInit()with a clear error, sinceRabbitTemplate.receive()only accepts a single queue name. Also trims the queue name inreceive().Test plan
DefaultListenerContainerFactoryTest— verifies queue names are trimmed after splitting"myqueue, myotherqueue"SpringRabbitPollingConsumerTest— verifiesdoInit()throwsIllegalArgumentExceptionfor multi-queue config🤖 Generated with Claude Code
Co-Authored-By: Claude Opus 4.6 noreply@anthropic.com