[CALCITE-5168] Allow AS after parenthesized JOIN - #5193
Open
xuzifu666 wants to merge 2 commits into
Open
Conversation
xuzifu666
commented
Aug 19, 2026
| !ok | ||
|
|
||
| # [CALCITE-5168] Allow AS after parenthesized JOIN | ||
| select d.dname, j.empno, j.ename |
Member
Author
There was a problem hiding this comment.
This sql programe was validated in postgresql: https://onecompiler.com/postgresql/44ypqwt2u
|
mihaibudiu
approved these changes
Aug 19, 2026
| // not unique. TODO: Support this behavior; see | ||
| // [CALCITE-5168] Allow AS after parenthesized JOIN | ||
| checkNotJoin(tableRef); | ||
| // not unique. See [CALCITE-5168] Allow AS after parenthesized JOIN. |
Contributor
There was a problem hiding this comment.
I would suggest removing the last sentence. It works, fine, we don't know when it was introduced.
| // For an aliased join, the join's children must not be visible outside | ||
| // the alias. Prevent JoinScope.addChild from propagating children to | ||
| // the using scope by using parentScope. | ||
| final SqlValidatorScope exprUsingScope = |
Contributor
There was a problem hiding this comment.
this is subtle, but the tests pass, so I hope it's right
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
jira: https://issues.apache.org/jira/browse/CALCITE-5168