[CALCITE-6781] The isUpdateCapable method of calcite.avatica will incorrectly traverse the returned result value#302
Merged
caicancai merged 1 commit intoapache:mainfrom Apr 30, 2026
Conversation
…orrectly traverse the returned result value
caicancai
force-pushed
the
test-calcite-6781-update-count
branch
from
efefac8 to
82bebb5
Compare
mihaibudiu
approved these changes
Apr 29, 2026
Contributor
mihaibudiu
left a comment
mihaibudiu
left a comment
There was a problem hiding this comment.
This looks fine, but it's not easy to confirm that it will work end-to-end.
Did you manage to build a version of Calcite using an updated Avatica to check that this will work?
Member
Author
Of course, I have already verified this within the company. |
Member
Author
|
@mihaibudiu thank you for your review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://issues.apache.org/jira/browse/CALCITE-6781