build(example): extract shared CMake dependency helper for examples#3391
Open
darion-yaphet wants to merge 1 commit into
Open
build(example): extract shared CMake dependency helper for examples#3391darion-yaphet wants to merge 1 commit into
darion-yaphet wants to merge 1 commit into
Conversation
Example CMakeLists duplicated the same dependency discovery and link setup. Move that into brpc_example_find_common_deps in BrpcExample.cmake, migrate MySQL and other examples to use it, and implement the helper as a macro so CMAKE_PREFIX_PATH, include paths, and DYNAMIC_LIB propagate to the caller scope. Example-specific deps stay local (e.g. readline/ncurses/thriftnb for MySQL, gperftools for redis/http). LINK_SO behavior is unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Problem Summary:
Example
CMakeLists.txtfiles duplicate the same dependency discovery and link setup (brpc, protobuf, gflags, leveldb, openssl, thrift, Darwin flags). That makesMySQL and other examples hard to maintain and easy to drift.
What is changed and the side effects?
Changed:
brpc_example_find_common_depsinexample/cmake/BrpcExample.cmaketo centralize common dependency lookup andDYNAMIC_LIBconstruction.CMakeLists.txtfiles to call the helper, removing duplicated find/link boilerplate.macroso variables such asCMAKE_PREFIX_PATH, include paths, and library lists propagate to the caller scope.Side effects:
CMakeLists.txtshould usebrpc_example_find_common_deps/ existingBrpcExample.cmakehelpers instead of the removed duplicated blocks.LINK_SObehavior is preserved.Check List: