Log only overridden config in BookieServer startup#4768
Open
merlimat wants to merge 1 commit intoapache:masterfrom
Open
Log only overridden config in BookieServer startup#4768merlimat wants to merge 1 commit intoapache:masterfrom
merlimat wants to merge 1 commit intoapache:masterfrom
Conversation
Replace the JSON dump of the entire ServerConfiguration with a "Starting Bookie server" message that carries an "overrides" attribute holding only the entries that differ from the built-in defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BookieServerwas dumping the entireServerConfigurationas a formatted JSON blob at startup, which is huge and distracting in logs.Starting Bookie serverlog entry that carries anoverridesattribute containing only the config entries that differ from the built-in defaults.setProperty) and skipping anything whose value matches a freshnew ServerConfiguration().Test plan
mvn -pl bookkeeper-server compile test-compilepasses.bk_server.confand confirm the log entry shows only the user-set overrides, not the full config.