Skip to content

[IcebergIO] add test for column default values - #39739

Open
ahmedabu98 wants to merge 1 commit into
apache:masterfrom
ahmedabu98:test-default-read
Open

[IcebergIO] add test for column default values#39739
ahmedabu98 wants to merge 1 commit into
apache:masterfrom
ahmedabu98:test-default-read

Conversation

@ahmedabu98

Copy link
Copy Markdown
Contributor

Default column values is an Iceberg V3 feature: https://iceberg.apache.org/spec/#version-3-extended-types-and-capabilities

Add tests to verify that we support it (since we're using the latest Iceberg libraries)


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds integration test coverage for Iceberg V3 column default values in the Iceberg CDC incremental changelog reader, ensuring Beam’s IcebergIO correctly materializes defaulted values when reading older files after schema evolution.

Changes:

  • Add a test verifying that an older data file (written before schema evolution) is read with the new column’s initial default value.
  • Add a test verifying overwrite CDC semantics where the “before” row uses the initial default (old file) and the “after” row uses an explicitly written value (new file).
  • Add a small formatting DoFn used to assert defaulted vs explicit values in formatted CDC output.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@github-actions

Copy link
Copy Markdown
Contributor

Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment assign set of reviewers

@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.17%. Comparing base (a0e2714) to head (7e680bf).

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #39739      +/-   ##
============================================
+ Coverage     54.97%   58.17%   +3.20%     
- Complexity     1722    13104   +11382     
============================================
  Files          1071     2523    +1452     
  Lines        170836   265755   +94919     
  Branches       1262    10795    +9533     
============================================
+ Hits          93910   154600   +60690     
- Misses        74656   105336   +30680     
- Partials       2270     5819    +3549     
Flag Coverage Δ
java 64.27% <ø> (-3.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

Copy link
Copy Markdown
Contributor

Assigning reviewers:

R: @kennknowles for label java.

Note: If you would like to opt out of this review, comment assign to next reviewer.

Available commands:

  • stop reviewer notifications - opt out of the automated review tooling
  • remind me after tests pass - tag the comment author after tests pass
  • waiting on author - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)

The PR bot will only process comments in the main thread (not review comments).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants