fix: allow empty DynamoDB list and map in AttributeValueCoder - #39734
Open
waterWang wants to merge 1 commit into
Open
fix: allow empty DynamoDB list and map in AttributeValueCoder#39734waterWang wants to merge 1 commit into
waterWang wants to merge 1 commit into
Conversation
DynamoDB allows empty L (list) and M (map) attribute values, but AttributeValueCoder.encode rejects them because the `size() > 0` guard on these branches causes them to fall through to the terminal else. Remove the `size() > 0` guard for L and M branches. The decode side already handles empty lists and maps correctly. Fixes apache#39730
Contributor
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
AttributeValueCoder.encodecannot encode a DynamoDB attribute whose value is an empty list or an empty map — it throwsCoderException("Unknown Type").The
LandMbranches are guarded withsize() > 0:Fix
Remove the
size() > 0guard forLandMbranches. Thedecodeside already handles empty lists and maps correctly viaListCoder/MapCoder— onlyencoderejects them.Blast radius
A single empty list nested anywhere inside an item makes the whole item unencodable, because
MAP_ATTRIBUTE_CODERre-enters this coder for every child.Fixes #39730