Skip to content

Fix Dataflow job file validation on Windows #39708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ulofiai wants to merge 1 commit into
base: master
Choose a base branch
from
+3 −1
Open

Fix Dataflow job file validation on Windows #39708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion ...le-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1592,7 +1592,9 @@ public DataflowPipelineJob run(Pipeline pipeline) {
String fileLocation =
firstNonNull(options.getTemplateLocation(), options.getDataflowJobFile());
checkArgument(
fileLocation.startsWith("/") || fileLocation.startsWith("gs://"),
fileLocation.startsWith("/")

@Abacn Abacn Aug 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor performance consideration. Considering the ordering:

fileLocation.startsWith("/") || fileLocation.startsWith("gs://") || new File(fileLocation).isAbsolute()

Nowadays most likely it would be a gcs path. Put new the last one avoids new an object each time it's executed

|| new File(fileLocation).isAbsolute()
|| fileLocation.startsWith("gs://"),
"Location must be local or on Cloud Storage, got %s.",
fileLocation);

Expand Down
Loading