Disable gRPC fork support in PortableRunnerTestWithSubprocesses#38744
Conversation
Avoids deadline exceeded failures in subprocess tests. Redundant setup and teardown in the multi-worker subclass are removed to inherit them cleanly.
|
r: @derrickaw |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses intermittent test failures caused by gRPC fork support issues during subprocess execution. By centralizing the environment configuration in the base class and cleaning up redundant overrides in subclasses, the test suite becomes more stable and maintainable. Highlights
New Features🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request refactors portable_runner_test.py by moving the setUpClass and tearDownClass methods, which manage the GRPC_ENABLE_FORK_SUPPORT environment variable, from PortableRunnerTestWithSubprocessesAndMultiWorkers to its parent class PortableRunnerTestWithSubprocesses to avoid duplication. The reviewer recommends using cls.addClassCleanup within setUpClass instead of a separate tearDownClass to ensure environment variables are cleaned up properly even if super().setUpClass() fails.
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
Applying the fix in #38566 to its parent class.
Redundant setup and teardown in the multi-worker subclass are removed to inherit them cleanly.
Test failure example: