Skip to content

Test only - hugging face#38696

Draft
derrickaw wants to merge 7 commits into
masterfrom
20260524_huggingFaceTry#3
Draft

Test only - hugging face#38696
derrickaw wants to merge 7 commits into
masterfrom
20260524_huggingFaceTry#3

Conversation

@derrickaw
Copy link
Copy Markdown
Collaborator

Please add a meaningful description for your change here


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests
Go tests

See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces support for HuggingFace pipelines within the Apache Beam YAML SDK. It adds the necessary provider logic to handle model inference and includes a new integration test to verify the functionality. Additionally, the build system has been updated to manage ML-specific dependencies more effectively during the testing process.

Highlights

  • HuggingFace Integration: Added a new HuggingFacePipelineProvider to the YAML ML module, enabling seamless integration of HuggingFace models within Apache Beam YAML pipelines.
  • Test Infrastructure: Introduced a new YAML integration test for HuggingFace pipelines and updated the build configuration to include necessary dependencies for ML-based testing.
  • Build System Updates: Refactored YAML integration test dependencies to use a dedicated task, ensuring consistent environment setup across pre-commit and post-commit test suites.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (2)
    • .github/workflows/beam_PostCommit_Yaml_Xlang_Direct.yml
    • .github/workflows/beam_PreCommit_Yaml_Xlang_Direct.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Hugging Face pipelines in Apache Beam YAML by adding the HuggingFacePipelineProvider model handler, along with integration tests and a Gradle task to install the required dependencies. The review feedback highlights three important issues: a Gradle build error caused by escaping the buildDir variable (preventing its interpolation), a potential TypeError and incorrect return structure in the Hugging Face test pipeline's real_inference function, and a potential AttributeError in the validate method of HuggingFacePipelineProvider if the configuration is empty.

Comment thread sdks/python/build.gradle
Comment thread sdks/python/apache_beam/yaml/tests/runinference_huggingface.yaml
Comment thread sdks/python/apache_beam/yaml/yaml_ml.py
@derrickaw derrickaw marked this pull request as draft May 26, 2026 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant