AVRO-4271: [ruby] Use json instead of multi_json#3825
Open
ericproulx wants to merge 1 commit into
Open
Conversation
Assisted-By: devx/63fca10e-e960-41ef-b93a-054c5b25df5f
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
This resolves AVRO-4271 by switching the Ruby runtime dependency from
multi_jsonto thejsongem and updating Ruby JSON parsing/generation callsto use
JSONdirectly. It also removes the staleYajl.dumpcall in protocolmessage serialization.
Verifying this change
This change is already covered by existing tests. The following targeted tests
were run locally:
ruby -Ilib:test test/test_schema.rbruby -Ilib:test test/test_schema_normalization.rbruby -Ilib:test test/test_protocol.rbruby -Ilib:test test/test_datafile.rb --name test_differing_schemas_with_complex_objectsruby -Ilib:test test/test_io.rb --name '/test_(null|boolean|string|bytes|int|long|float|double)/'Documentation