AVRO-3760: [python] Fix resolution of future enum with default symbol - #2250
Merged
RyanSkraba merged 3 commits intoAug 5, 2026
Merged
Conversation
aiven-anton
force-pushed
the
fix/avro-3760-broken-future-enums
branch
from
May 24, 2023 15:29
f1d0f77 to
ac077a0
Compare
aiven-anton
changed the title
aiven-anton
force-pushed
the
fix/avro-3760-broken-future-enums
branch
from
May 24, 2023 20:11
ac077a0 to
6915637
Compare
aiven-anton
commented
May 24, 2023
| Sequence, | ||
| Union, | ||
| ) | ||
| from typing import IO, Generator, Iterable, List, Mapping, Optional, Sequence, Union |
Contributor
Author
There was a problem hiding this comment.
The Deque import was unused.
aiven-anton
force-pushed
the
fix/avro-3760-broken-future-enums
branch
from
May 26, 2023 08:09
6915637 to
8fa32e7
Compare
RyanSkraba
reviewed
Jun 15, 2023
kojiromike
reviewed
Jul 12, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the purpose of the change
Parsing an enum should resolve to the default symbol when the symbol is not known to the reader. This raised a SchemaResolutionError. The patch adds handling of default symbols, see AVRO-3760.
Verifying this change
The change adds tests that verifies that the behavior is now in line with the spec, but retains the current behavior when there is no default symbol.
Documentation