GH-50971: [C++][Parquet] Fix usage of disparate length types for metadata reading - #50972
Merged
Conversation
|
|
Member
Author
|
@HuaHuaY @adamreeve @wgtmac Do you want to take a look? |
adamreeve
reviewed
Aug 24, 2026
|
|
||
| /// \brief Size of the original thrift encoded metadata footer. | ||
| uint32_t size() const; | ||
| int64_t size() const; |
Contributor
There was a problem hiding this comment.
Should this be considered a breaking change? I think it's probably OK. Any existing consumer code might end up with a narrowing conversion when storing the result of this, or get a different type if they assign to an auto typed variable, but that should work out OK.
Member
Author
There was a problem hiding this comment.
I would optimistically say it's ok too. More importantly, I'm not sure anyone but us has a use for this API.
github-actions
Bot
added
awaiting committer review
Member
Author
|
@github-actions crossbow submit -g cpp |
|
Member
Author
Member
|
@rok we might require to update the token? I'm off but I can try and generate and add a new token later today |
Member
|
Most likely. I'll put mine in for now to check. |
Member
|
@github-actions crossbow submit -g cpp |
|
Revision: 671358f Submitted crossbow builds: ursacomputing/crossbow @ actions-4821e33666
|
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
The usage of disparate integer types (
int64_t,uint32_t) makes our checks and computations fragile, especially with C++ adding its own integer promotion rules across arithmetic operations.We have had at least one report (courtesy of Ada Logics and Claude) where a carefully crafted Parquet file can read from an invalid pointer due to arithmetic overflow in the 32-bit domain.
What changes are included in this PR?
Use
int64_tthroughout most internal APIs and code paths when reading Parquet metadata. Other types such asuint32_tshould only be used where necessary when interacting with third-party libraries such as Thrift C++.Are these changes tested?
By existing tests, and manually using said hand-crafted Parquet file.
Are there any user-facing changes?
Some APIs taking a
uint32_t*inout-parameter are deprecated, alternatives taking aint64_tvalue are available.