GH-49921: [C++] Bump xsimd to 14.2.0 by AntoinePrv · Pull Request #49922 · apache/arrow

AntoinePrv · 2026-05-05T13:09:35Z

Rationale for this change

Fix for the current SVE ODR violation in the latest version
Fix SVE dynamic dispatch ODR violation xtensor-stack/xsimd#1311
Pre-requisit to [C++] Use existing library for CPU detection #45331

What changes are included in this PR?

Bump version and cleanup backports.

Are these changes tested?

Yes, in CI.

Are there any user-facing changes?

No

GitHub Issue: [C++] Bump xsimd to 14.2.0 #49921

github-actions · 2026-05-05T13:10:25Z

⚠️ GitHub issue #49921 has been automatically assigned in GitHub to PR creator.

pitrou · 2026-05-06T09:11:20Z

@AntoinePrv Can you take a look at the CI failures? They seem related.

AntoinePrv · 2026-05-06T09:12:36Z

Yes, I am still waiting for the Msys2 build of xsimd to happen...

pitrou · 2026-05-06T09:14:37Z

There are failures on non-MSys2 builds, though:

AntoinePrv · 2026-05-06T09:30:33Z

Perhaps it's this check that does not work on MSVC?

https://github.com/xtensor-stack/xsimd/blob/80c23624ce008d937da7e845e528e82ce0cbf4e0/include/xsimd/types/xsimd_batch_constant.hpp#L500

Either we could add /Zc:__cplusplus or re-introduce the backport.

pitrou · 2026-05-06T09:49:52Z

I think we should both 1) fix xsimd upstream anyway and 2) pass /Zc:__cplusplus when building Arrow C++.

It seems xsimd should do something like this:

#ifdef _MSVC_LANG
#define XSIMD_CPP_LEVEL _MSVC_LANG
#else
#define XSIMD_CPP_LEVEL __cplusplus
#endif

and then use the XSIMD_CPP_LEVEL macro everywhere instead of __cplusplus.

(but xsimd could also use find-grained feature testing).

AntoinePrv · 2026-05-06T09:51:33Z

Already sending a patch, but not sure I want to go through another round of xsimd releases

xtensor-stack/xsimd#1342

pitrou · 2026-05-06T09:59:38Z

Agreed, hence "pass /Zc:__cplusplus when building Arrow C++" as well 😉

pitrou · 2026-05-06T10:41:57Z

Bloody protobuf fails building with /Zc:__cplusplus.
https://github.com/apache/arrow/actions/runs/25429128655/job/74590408553?pr=49922#step:9:2218

pitrou · 2026-05-06T11:24:58Z

Tiny syntax error that needs fixing:

  #17 27.36 Failed to load manifest from directory /arrow/ci/vcpkg
  #17 27.36 /arrow/ci/vcpkg/vcpkg.json:24:26: error: Trailing comma in an object
  #17 27.36   on expression:       "version>=": "14.2",

AntoinePrv · 2026-05-06T12:43:05Z

@pitrou I'm not very proactively working on this until the msys2 xsimd build is live

pitrou · 2026-05-06T14:19:52Z

@pitrou I'm not very proactively working on this until the msys2 xsimd build is live

@kou Do you know how we can make that happen?

pitrou · 2026-05-06T14:20:30Z

@github-actions crossbow submit -g cpp

github-actions · 2026-05-06T14:23:15Z

Revision: 89a1f7e

Submitted crossbow builds: ursacomputing/crossbow @ actions-9c434593fe

Task	Status
example-cpp-minimal-build-static
example-cpp-minimal-build-static-system-dependency
example-cpp-tutorial
test-build-cpp-fuzz
test-conda-cpp
test-conda-cpp-valgrind
test-debian-13-cpp-amd64
test-debian-13-cpp-i386
test-debian-experimental-cpp-gcc-15
test-fedora-42-cpp
test-ubuntu-22.04-cpp
test-ubuntu-22.04-cpp-bundled
test-ubuntu-22.04-cpp-emscripten
test-ubuntu-22.04-cpp-no-threading
test-ubuntu-24.04-cpp
test-ubuntu-24.04-cpp-bundled-offline
test-ubuntu-24.04-cpp-gcc-13-bundled
test-ubuntu-24.04-cpp-gcc-14
test-ubuntu-24.04-cpp-minimal-with-formats
test-ubuntu-24.04-cpp-thread-sanitizer

raulcd · 2026-05-06T14:41:25Z

Do you know how we can make that happen?

It's just a matter of waiting for their queue to update it:
https://packages.msys2.org/queue

Based on experience when uploading Arrow it takes between 6 and 12 hours. Their CI seems to run several times a day and xsimd is already listed on the queue so it should be available "soon".

raulcd · 2026-06-02T08:36:12Z

@github-actions crossbow submit wheelcp314

github-actions · 2026-06-02T08:39:56Z

Revision: 3f697f0

Submitted crossbow builds: ursacomputing/crossbow @ actions-5ec367f3ef

Task	Status
wheel-macos-monterey-cp314-cp314-amd64
wheel-macos-monterey-cp314-cp314-arm64
wheel-macos-monterey-cp314-cp314t-amd64
wheel-macos-monterey-cp314-cp314t-arm64
wheel-manylinux-2-28-cp314-cp314-amd64
wheel-manylinux-2-28-cp314-cp314-arm64
wheel-manylinux-2-28-cp314-cp314t-amd64
wheel-manylinux-2-28-cp314-cp314t-arm64
wheel-musllinux-1-2-cp314-cp314-amd64
wheel-musllinux-1-2-cp314-cp314-arm64
wheel-musllinux-1-2-cp314-cp314t-amd64
wheel-musllinux-1-2-cp314-cp314t-arm64
wheel-windows-cp314-cp314-amd64
wheel-windows-cp314-cp314t-amd64

Copilot

Pull request overview

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

  if constexpr (kIsSse2 && (IntSize != sizeof(uint64_t))) {
    constexpr Int kMaxRShift = max_value(std::array{kShifts...});

    constexpr auto kLShifts =
        xsimd::make_batch_constant<Int, kMaxRShift, Arch>() - shifts;

-    return xsimd::bitwise_rshift<kMaxRShift>(left_shift(batch, kLShifts));
-  }
-
-  // TODO(xsimd) bug fixed in xsimd 14.1.0
-  // https://github.com/xtensor-stack/xsimd/pull/1266
-#if XSIMD_VERSION_MAJOR < 14 || ((XSIMD_VERSION_MAJOR == 14) && XSIMD_VERSION_MINOR == 0)
-  if constexpr (IsNeon<Arch>) {
-    using SInt = std::make_signed_t<Int>;
-    constexpr auto signed_shifts =
-        xsimd::batch_constant<SInt, Arch, static_cast<SInt>(kShifts)...>();
-    return xsimd::kernel::bitwise_rshift(batch, signed_shifts.as_batch(), Arch{});
+    return xsimd::bitwise_rshift<kMaxRShift>(batch << kLShifts);
  }


raulcd · 2026-06-02T08:58:10Z

@github-actions crossbow submit wheelcp314

github-actions · 2026-06-02T09:00:50Z

Revision: 22ffada

Submitted crossbow builds: ursacomputing/crossbow @ actions-575ab77839

Task	Status
wheel-macos-monterey-cp314-cp314-amd64
wheel-macos-monterey-cp314-cp314-arm64
wheel-macos-monterey-cp314-cp314t-amd64
wheel-macos-monterey-cp314-cp314t-arm64
wheel-manylinux-2-28-cp314-cp314-amd64
wheel-manylinux-2-28-cp314-cp314-arm64
wheel-manylinux-2-28-cp314-cp314t-amd64
wheel-manylinux-2-28-cp314-cp314t-arm64
wheel-musllinux-1-2-cp314-cp314-amd64
wheel-musllinux-1-2-cp314-cp314-arm64
wheel-musllinux-1-2-cp314-cp314t-amd64
wheel-musllinux-1-2-cp314-cp314t-arm64
wheel-windows-cp314-cp314-amd64
wheel-windows-cp314-cp314t-amd64

raulcd

CI failures are unrelated. We should merge this now. Thanks @AntoinePrv !

raulcd

Sorry, just thought about this, I am happy to merge as is.
Are we planning to bump this requirement later on when we improve the cpu detection feature?

arrow/cpp/cmake_modules/ThirdpartyToolchain.cmake

Lines 2855 to 2861 in 3d4ab3f

    
           resolve_dependency(xsimd 
        
                              FORCE_ANY_NEWER_VERSION 
        
                              TRUE 
        
                              IS_RUNTIME_DEPENDENCY 
        
                              FALSE 
        
                              REQUIRED_VERSION 
        
                              "14.0.0")

raulcd · 2026-06-02T15:58:12Z

@github-actions crossbow submit wheelcp314

github-actions · 2026-06-02T16:00:53Z

Revision: 8278222

Submitted crossbow builds: ursacomputing/crossbow @ actions-0d5b743af7

Task	Status
wheel-macos-monterey-cp314-cp314-amd64
wheel-macos-monterey-cp314-cp314-arm64
wheel-macos-monterey-cp314-cp314t-amd64
wheel-macos-monterey-cp314-cp314t-arm64
wheel-manylinux-2-28-cp314-cp314-amd64
wheel-manylinux-2-28-cp314-cp314-arm64
wheel-manylinux-2-28-cp314-cp314t-amd64
wheel-manylinux-2-28-cp314-cp314t-arm64
wheel-musllinux-1-2-cp314-cp314-amd64
wheel-musllinux-1-2-cp314-cp314-arm64
wheel-musllinux-1-2-cp314-cp314t-amd64
wheel-musllinux-1-2-cp314-cp314t-arm64
wheel-windows-cp314-cp314-amd64
wheel-windows-cp314-cp314t-amd64

AntoinePrv requested review from assignUser, jonkeane, kou and raulcd as code owners May 5, 2026 13:09

github-actions Bot added Component: C++ awaiting review Awaiting review labels May 5, 2026

AntoinePrv changed the title ~~GH-49921: [C++] Bunp xsimd to 14.2.0~~ GH-49921: [C++] Bump xsimd to 14.2.0 May 5, 2026

AntoinePrv force-pushed the main branch from 20b6061 to 474dc03 Compare May 6, 2026 07:21

AntoinePrv force-pushed the main branch from 7df3806 to 18d7351 Compare May 6, 2026 10:29

pitrou added the CI: Extra: C++ Run extra C++ CI label May 6, 2026

github-actions Bot removed the CI: Extra: C++ Run extra C++ CI label May 6, 2026

pitrou added the CI: Extra: C++ Run extra C++ CI label May 6, 2026

AntoinePrv mentioned this pull request May 6, 2026

GH-45331: Use xsimd for CPU feature detection #49940

Draft

github-actions Bot removed the CI: Extra: C++ Run extra C++ CI label May 6, 2026

pitrou added the CI: Extra: C++ Run extra C++ CI label May 7, 2026

raulcd reviewed Jun 2, 2026

View reviewed changes

Comment thread ci/vcpkg/vcpkg.json Outdated

Revert VCPKG xsimd version

22ffada

Copilot AI review requested due to automatic review settings June 2, 2026 08:53

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 2, 2026

Copilot AI reviewed Jun 2, 2026

View reviewed changes

github-actions Bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Jun 2, 2026

github-actions Bot added awaiting changes Awaiting changes and removed awaiting change review Awaiting change review labels Jun 2, 2026

raulcd added CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI labels Jun 2, 2026

raulcd approved these changes Jun 2, 2026

View reviewed changes

github-actions Bot added awaiting merge Awaiting merge and removed awaiting changes Awaiting changes labels Jun 2, 2026

raulcd reviewed Jun 2, 2026

View reviewed changes

github-actions Bot added awaiting changes Awaiting changes and removed awaiting merge Awaiting merge labels Jun 2, 2026

Bump xsimd Cmake requirement

8278222

github-actions Bot added awaiting change review Awaiting change review and removed CI: Extra: C++ Run extra C++ CI CI: Extra: Package: Linux Run extra Linux Packages CI awaiting changes Awaiting changes labels Jun 2, 2026

raulcd added the CI: Extra: Package: Linux Run extra Linux Packages CI label Jun 2, 2026

	resolve_dependency(xsimd
	FORCE_ANY_NEWER_VERSION
	TRUE
	IS_RUNTIME_DEPENDENCY
	FALSE
	REQUIRED_VERSION
	"14.0.0")

Conversation

AntoinePrv commented May 5, 2026 • edited by github-actions Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

pitrou commented May 6, 2026

Uh oh!

AntoinePrv commented May 6, 2026

Uh oh!

pitrou commented May 6, 2026

Uh oh!

AntoinePrv commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pitrou commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

AntoinePrv commented May 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

pitrou commented May 6, 2026

Uh oh!

pitrou commented May 6, 2026

Uh oh!

pitrou commented May 6, 2026

Uh oh!

AntoinePrv commented May 6, 2026

Uh oh!

pitrou commented May 6, 2026

Uh oh!

pitrou commented May 6, 2026

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

raulcd commented May 6, 2026

Uh oh!

raulcd commented Jun 2, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

raulcd commented Jun 2, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

raulcd left a comment

Choose a reason for hiding this comment

Uh oh!

raulcd commented Jun 2, 2026

Uh oh!

github-actions Bot commented Jun 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AntoinePrv commented May 5, 2026 •

edited by github-actions Bot

Loading

AntoinePrv commented May 6, 2026 •

edited

Loading

pitrou commented May 6, 2026 •

edited

Loading

AntoinePrv commented May 6, 2026 •

edited

Loading