GH-49706 [C++][Parquet] Make writing of path_in_schema optional#49707
Draft
etseidl wants to merge 6 commits intoapache:mainfrom
Draft
GH-49706 [C++][Parquet] Make writing of path_in_schema optional#49707etseidl wants to merge 6 commits intoapache:mainfrom
path_in_schema optional#49707etseidl wants to merge 6 commits intoapache:mainfrom
Conversation
|
|
github-actions
bot
added
Component: Parquet
Component: C++
awaiting committer review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
path_in_schemain theColumnMetaDatais redundant. apache/parquet-format#563 proposes fixing this by marking the fieldoptionalin the Thrift definition.What changes are included in this PR?
Modify the thrift generated code after makeing
path_in_schemaoptional. Add options toWriterPropertiesto control the behavior, with the default being to continue writing the field. Makes changes to the metadata to account for the field now being optional.Are these changes tested?
Yes, adds a unit test to confirm the field is not present when that is requested.
Are there any user-facing changes?
Adds a new configuration option, but no behavioral changes by default.
ColumnMetaData.path_in_schemaoptional #49706ColumnMetaData.path_in_schemaoptional #49706