GH-48068: [C++][FlightRPC] Linux ODBC: Configure Dremio instance to allow remote testing by alinaliBQ · Pull Request #49695 · apache/arrow

alinaliBQ · 2026-04-08T21:40:33Z

Rationale for this change

The goal is to run remote tests against the Dremio instance on Ubuntu-latest runner, as Dremio docker instances are only available on Linux and they are not supported on macOS/Windows GitHub Actions.

What changes are included in this PR?

Added docker-compose.yml.
Added logic for setting up dremio account and creating a table.
Add ODBC remote test connection variable.
set up Dremio remote instance in CI

Note: Enabling Linux tests in CI will be in a separate PR. This PR prepares the Dremio instance for remote testing, which will be used when ODBC Linux tests are supported in CI.

Are these changes tested?

Tested in CI at local repository.

Are there any user-facing changes?

N/A

GitHub Issue: [C++] [Flight SQL ODBC] Set Up Linux ODBC Driver Tests Against Dremio Docker #48068

Authored by Justin Co-authored-by: justing-bq <justin.gossett@improving.com>

* Disable non-odbc workflows * Install `netcat` and set `ARROW_FLIGHT_SQL_ODBC_CONN` * Attempt to enable docker network Update compose.yaml Add executable bash script * add commands for testing Dremio instance value * Change to use `host.docker.internal` * Change test to run remote test Update cpp_extra.yml * Use `localhost` as hostname * Use `dremio_container` as host * Clean up PR * Test remote instance * CI can connect to remote instance, revert "Test remote instance" This reverts commit db975bf. * Disable ODBC Debian build * Seeing segfault at ODBC test. Can probably be solved by passing test linkage = static like we did with Ubuntu. Since we don't have capacity to work on Debian now, we can close this.

github-actions · 2026-04-08T21:41:28Z

⚠️ GitHub issue #48068 has been automatically assigned in GitHub to PR creator.

alinaliBQ · 2026-04-09T16:24:11Z

@lidavidm @kou This PR is ready for review, please have a look

lidavidm · 2026-04-09T23:52:18Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/docker-compose.yml

Is there a reason we can't keep this in the same compose file as everything else?

I have moved this inside the same compose file at project root. There is no preference from my end

kou · 2026-04-10T01:16:17Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/docker-compose.yml

Could you compose.yaml because it's the preferred file name?
See also: #47806

Yup, I have moved this inside the compose.yaml at project root.

kou · 2026-04-10T01:17:22Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh

+# specific language governing permissions and limitations
+# under the License.
+
+#!/bin/bash


Could you move the shebang to the first line?

kou · 2026-04-10T01:17:58Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh

Could you enable pre-commit hooks for this file?

kou · 2026-04-10T01:23:41Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh

+     -d "{ \"userName\": \"$ADMIN_USER\", \"password\": \"$ADMIN_PASSWORD\" }" \
+     | grep -oP '(?<="token":")[^"]+')
+
+SQL_QUERY="Create Table \$scratch.ODBCTest As SELECT CAST(2147483647 AS INTEGER) AS sinteger_max, CAST(9223372036854775807 AS BIGINT) AS sbigint_max, CAST(999999999 AS DECIMAL(38,0)) AS decimal_positive, CAST(3.40282347E38 AS FLOAT) AS float_max, CAST(1.7976931348623157E308 AS DOUBLE) AS double_max, CAST(true AS BOOLEAN) AS bit_true, CAST(DATE '9999-12-31' AS DATE) AS date_max, CAST(TIME '23:59:59' AS TIME) AS time_max, CAST(TIMESTAMP '9999-12-31 23:59:59' AS TIMESTAMP) AS timestamp_max;"


How about format this for easy to read?

Suggested change

SQL_QUERY="Create Table \$scratch.ODBCTest As SELECT CAST(2147483647 AS INTEGER) AS sinteger_max, CAST(9223372036854775807 AS BIGINT) AS sbigint_max, CAST(999999999 AS DECIMAL(38,0)) AS decimal_positive, CAST(3.40282347E38 AS FLOAT) AS float_max, CAST(1.7976931348623157E308 AS DOUBLE) AS double_max, CAST(true AS BOOLEAN) AS bit_true, CAST(DATE '9999-12-31' AS DATE) AS date_max, CAST(TIME '23:59:59' AS TIME) AS time_max, CAST(TIMESTAMP '9999-12-31 23:59:59' AS TIMESTAMP) AS timestamp_max;"

SQL_QUERY="

Create Table \$scratch.ODBCTest As

SELECT CAST(2147483647 AS INTEGER) AS sinteger_max,

CAST(9223372036854775807 AS BIGINT) AS sbigint_max,

CAST(999999999 AS DECIMAL(38,0)) AS decimal_positive,

CAST(3.40282347E38 AS FLOAT) AS float_max,

CAST(1.7976931348623157E308 AS DOUBLE) AS double_max,

CAST(true AS BOOLEAN) AS bit_true,

CAST(DATE '9999-12-31' AS DATE) AS date_max,

CAST(TIME '23:59:59' AS TIME) AS time_max,

CAST(TIMESTAMP '9999-12-31 23:59:59' AS TIMESTAMP) AS timestamp_max;

"

Done! Thanks

- Move `dremio` to `compose.yaml` at project root - Move shebang to first line - add `set_up_dremio_instance.sh` to pre-commit hook - Fix `SQL_QUERY` variable format

alinaliBQ

Addressed code review comments

alinaliBQ · 2026-04-10T20:34:39Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/docker-compose.yml

I have moved this inside the same compose file at project root. There is no preference from my end

alinaliBQ · 2026-04-10T20:41:10Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/docker-compose.yml

Yup, I have moved this inside the compose.yaml at project root.

alinaliBQ · 2026-04-10T20:43:01Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh

+# specific language governing permissions and limitations
+# under the License.
+
+#!/bin/bash


alinaliBQ · 2026-04-10T20:45:21Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh

alinaliBQ · 2026-04-10T20:47:28Z

cpp/src/arrow/flight/sql/odbc/tests/dremio/set_up_dremio_instance.sh

+     -d "{ \"userName\": \"$ADMIN_USER\", \"password\": \"$ADMIN_PASSWORD\" }" \
+     | grep -oP '(?<="token":")[^"]+')
+
+SQL_QUERY="Create Table \$scratch.ODBCTest As SELECT CAST(2147483647 AS INTEGER) AS sinteger_max, CAST(9223372036854775807 AS BIGINT) AS sbigint_max, CAST(999999999 AS DECIMAL(38,0)) AS decimal_positive, CAST(3.40282347E38 AS FLOAT) AS float_max, CAST(1.7976931348623157E308 AS DOUBLE) AS double_max, CAST(true AS BOOLEAN) AS bit_true, CAST(DATE '9999-12-31' AS DATE) AS date_max, CAST(TIME '23:59:59' AS TIME) AS time_max, CAST(TIMESTAMP '9999-12-31 23:59:59' AS TIMESTAMP) AS timestamp_max;"


Done! Thanks

alinaliBQ and others added 2 commits April 8, 2026 14:31

Dremio Docker Container and Setup Script

e97ab4c

Authored by Justin Co-authored-by: justing-bq <justin.gossett@improving.com>

github-actions bot added Component: C++ Component: FlightRPC CI: Extra: C++ Run extra C++ CI awaiting review Awaiting review labels Apr 8, 2026

alinaliBQ marked this pull request as ready for review April 9, 2026 16:24

alinaliBQ requested review from assignUser, jonkeane, kou, lidavidm and raulcd as code owners April 9, 2026 16:24

lidavidm reviewed Apr 9, 2026

View reviewed changes

github-actions bot added awaiting changes Awaiting changes and removed awaiting review Awaiting review labels Apr 9, 2026

kou reviewed Apr 10, 2026

View reviewed changes

github-actions bot added awaiting change review Awaiting change review and removed awaiting changes Awaiting changes labels Apr 10, 2026

alinaliBQ force-pushed the gh-48068-dremio-docker-test branch 2 times, most recently from 3f9bd41 to 7b6d340 Compare April 10, 2026 21:17

Address feedback

4a892cf

- Move `dremio` to `compose.yaml` at project root - Move shebang to first line - add `set_up_dremio_instance.sh` to pre-commit hook - Fix `SQL_QUERY` variable format

alinaliBQ force-pushed the gh-48068-dremio-docker-test branch from 7b6d340 to 4a892cf Compare April 10, 2026 21:20

alinaliBQ commented Apr 10, 2026

View reviewed changes

Conversation

alinaliBQ commented Apr 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rationale for this change

What changes are included in this PR?

Are these changes tested?

Are there any user-facing changes?

Uh oh!

github-actions bot commented Apr 8, 2026

Uh oh!

alinaliBQ commented Apr 9, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alinaliBQ left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

alinaliBQ commented Apr 8, 2026 •

edited

Loading