perf(arrow/array): bulk append fixed-size list nulls and empty values - #1183
Open
fallintoplace wants to merge 2 commits into
Open
perf(arrow/array): bulk append fixed-size list nulls and empty values#1183fallintoplace wants to merge 2 commits into
fallintoplace wants to merge 2 commits into
Conversation
fallintoplace
marked this pull request as draft
August 12, 2026 12:18
fallintoplace
marked this pull request as ready for review
August 12, 2026 20:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
AppendNullsandAppendEmptyValuesThe child append count is
listSize * n, so the parent and child lengths stay in sync.Why?
Both methods currently loop over every parent value. Each parent append also loops over every child value.
This removes the parent loop and lets child builders use their bulk append paths. The change is independent, but it also composes with #1173 and #1180.
Benchmarks
Apple M1 Pro, 65,536
FixedSizeList<Int32>rows,GOMAXPROCS=1.Standalone on
main:With #1173 and #1180 applied underneath:
Tests
go test ./arrow/...go test -race ./arrow/arraygo vet ./arrow/array