perf(parquet/pqarrow): decode booleans directly to bitmaps - #1182
Draft
fallintoplace wants to merge 1 commit into
Draft
perf(parquet/pqarrow): decode booleans directly to bitmaps#1182fallintoplace wants to merge 1 commit into
fallintoplace wants to merge 1 commit into
Conversation
fallintoplace
marked this pull request as draft
August 12, 2026 12:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
[]boolWhy?
The read path currently stores decoded booleans as one byte per value. It then allocates an Arrow bitmap and packs the values again in
transferBool.This finishes wiring the direct bitmap decoder API from #707 into the pqarrow read path. The record reader now keeps boolean values packed from decoding through Arrow array construction.
The change also fixes decoder state after a partial PLAIN bitmap decode, so the next call resumes at the correct source bit.
Benchmarks
Apple M1 Pro, 1M values, uncompressed Parquet,
GOMAXPROCS=1:Tests
go test ./parquet/...go vetfor the touched packages