perf(parquet): optimize numeric dictionary insertion - #1178
Merged
zeroshade merged 1 commit intoAug 17, 2026
Merged
Conversation
fallintoplace
marked this pull request as ready for review
August 14, 2026 21:24
zeroshade
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
PutcallsWhy
The numeric path was calling the generic dictionary insertion method for every value. That added interface and reflection overhead, and the index buffer could grow inside the hot loop.
The new path does the memo lookup with the concrete numeric type and sizes the index buffer once per batch. Dictionary order, duplicate handling, and encoded indices stay the same.
Benchmark
With 65,535 values and 100 unique values on an Apple M1 Pro:
Validation
go test ./parquet/internal/encoding -count=1go vet ./parquet/internal/encodinggit diff --check