Fix executor_config reference aliasing across tasks and DAGs (#72544) - #72563
Open
abhijeets25012-tech wants to merge 1 commit into
Open
Fix executor_config reference aliasing across tasks and DAGs (#72544)#72563abhijeets25012-tech wants to merge 1 commit into
executor_config reference aliasing across tasks and DAGs (#72544)#72563abhijeets25012-tech wants to merge 1 commit into
Conversation
abhijeets25012-tech
requested review from
amoghrajesh,
ashb and
kaxil
as code owners
September 5, 2026 12:53
Contributor
Author
|
Hi maintainers, this PR is ready for review. Note: The failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #72544
_get_parent_defaultspreviously usedcopy.copy(shallow copy) when mergingdag.default_args. This caused nested mutable structures, specificallyexecutor_config, to be shared by object reference across all tasks and DAGs inheriting from those shared defaults. Consequently, runtime mutations totask.executor_config(such as setting Kubernetes pod overrides) silently modified sibling tasks and unrelated DAGs.This PR updates
_get_parent_defaultsto usecopy.deepcopyand explicitly deep-copiesexecutor_configduringBaseOperatorinitialization, ensuring strict reference isolation across task definitions.Changes Made
task-sdk/src/airflow/sdk/bases/operator.py:copy.copy(dag.default_args)withcopy.deepcopy(dag.default_args)in_get_parent_defaults.self.executor_configassignment inBaseOperator.__init__to usecopy.deepcopy(executor_config)to isolate both explicit and inherited configurations.