Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion task-sdk/src/airflow/sdk/definitions/dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ def _create_timetable(interval: ScheduleInterval, timezone: Timezone | FixedTime
if interval == "@continuous":
return ContinuousTimetable()
if isinstance(interval, timedelta | relativedelta):
if airflow_conf.getboolean("scheduler", "create_cron_data_intervals"):
if airflow_conf.getboolean("scheduler", "create_delta_data_intervals"):
return DeltaDataIntervalTimetable(interval)
return DeltaTriggerTimetable(interval)
if isinstance(interval, str):
Expand Down
40 changes: 40 additions & 0 deletions task-sdk/tests/task_sdk/definitions/test_dag.py
Original file line number Diff line number Diff line change
Expand Up @@ -447,6 +447,46 @@ def test_continuous_schedule_linmits_max_active_runs(self):
with pytest.raises(ValueError, match="ContinuousTimetable requires max_active_runs <= 1"):
dag = DAG("continuous", start_date=DEFAULT_DATE, schedule="@continuous", max_active_runs=25)

def test_timedelta_schedule_respects_create_delta_data_intervals_config(self):
"""Regression guard: create_delta_data_intervals must control DeltaTriggerTimetable vs
DeltaDataIntervalTimetable for timedelta/relativedelta schedules, independently of
create_cron_data_intervals (which governs only cron-string schedules).
"""
from airflow.sdk.definitions.timetables.interval import DeltaDataIntervalTimetable
from airflow.sdk.definitions.timetables.trigger import DeltaTriggerTimetable

from tests_common.test_utils.config import conf_vars

# Both False (the shipped airflow.cfg default): timedelta schedules use the trigger-based timetable.
with conf_vars(
{
("scheduler", "create_delta_data_intervals"): "False",
("scheduler", "create_cron_data_intervals"): "False",
}
):
dag = DAG("delta_default", start_date=DEFAULT_DATE, schedule=timedelta(days=1))
assert isinstance(dag.timetable, DeltaTriggerTimetable)

# create_delta_data_intervals=True switches timedelta schedules to the data-interval timetable.
with conf_vars(
{
("scheduler", "create_delta_data_intervals"): "True",
("scheduler", "create_cron_data_intervals"): "False",
}
):
dag = DAG("delta_data_interval", start_date=DEFAULT_DATE, schedule=timedelta(days=1))
assert isinstance(dag.timetable, DeltaDataIntervalTimetable)

# create_cron_data_intervals only affects cron/str schedules, not timedelta ones.
with conf_vars(
{
("scheduler", "create_delta_data_intervals"): "False",
("scheduler", "create_cron_data_intervals"): "True",
}
):
dag = DAG("delta_unaffected_by_cron_config", start_date=DEFAULT_DATE, schedule=timedelta(days=1))
assert isinstance(dag.timetable, DeltaTriggerTimetable)

def test_only_partitioned_at_runtime_has_partitioned_at_runtime_flag(self):
"""Regression guard: across every BaseTimetable subclass, only PartitionedAtRuntime sets partitioned_at_runtime=True."""

Expand Down