Handle TaskNotFound in triggerer to prevent stale triggers from blocking batch#69852
Open
hanumanraj07 wants to merge 2 commits into
Open
Handle TaskNotFound in triggerer to prevent stale triggers from blocking batch#69852hanumanraj07 wants to merge 2 commits into
hanumanraj07 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Catches
TaskNotFoundin the triggerer supervisor's_create_workloadmethod so that one stale task-associated trigger cannot abort the entire batch of healthy trigger workloads.Closes: #69841
Why
The triggerer supervisor loads the pinned serialized Dag for every task-associated trigger to check whether the task uses
start_from_trigger. If the serialized Dag exists but no longer contains the deferred task,get_task()raisesTaskNotFound. The exception escapes the per-batch loop inbuild_trigger_workloads, so one stale task instance prevents unrelated healthy triggers in the same batch from starting and can repeatedly restart the triggerer supervisor.How
get_task()in_create_workloadwith atry/except TaskNotFoundblocktask = None, falling through to the context-freeRunTriggerreturn (matching behavior whenserialized_dag_modelisNone)task.start_from_triggercheck totask is not None and task.start_from_trigger