Extract Cloud Logging labels from AF3 log path when task_instance is missing in supervisor context#68246
Open
goingforstudying-ctrl wants to merge 2 commits into
Conversation
boring-cyborg
Bot
added
area:logging
area:providers
provider:google
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
goingforstudying-ctrl
force-pushed
the
fix/stackdriver-labels-from-path
branch
23 times, most recently
from
dc7f1d1 to
6ba2072
Compare
goingforstudying-ctrl
force-pushed
the
fix/stackdriver-labels-from-path
branch
19 times, most recently
from
c3298d7 to
85ec4b8
Compare
shahar1
changed the title
shahar1
requested changes
Jun 17, 2026
Comment on lines
+187
to
+189
| # Parse labels from the structured log path as additional fallback. | ||
| path_labels = _labels_from_path(str(relative)) | ||
| labels.update(path_labels) |
Contributor
There was a problem hiding this comment.
It overrides event-derived labels rather than acting as a "fallback"
There was a problem hiding this comment.
Fixed. Path labels now only fill in missing keys rather than calling update() on the whole dict.
| return "\n".join(messages), page.next_page_token | ||
|
|
||
|
|
||
| def _labels_from_path(relative_path: str) -> dict[str, str]: |
Contributor
There was a problem hiding this comment.
should be renamed to _extract_labels_from_path
There was a problem hiding this comment.
Renamed to _extract_labels_from_path as requested.
Comment on lines
+310
to
+314
| elif key == "run_id": | ||
| # run_id is NOT a standard Stackdriver label yet, but it is used | ||
| # on the write side via the log path template. Store it so the | ||
| # read path can filter on it (Bug 2 will wire this up). | ||
| pass |
Contributor
There was a problem hiding this comment.
Currently it seems like a no-op, so I'd rather drop this branch
There was a problem hiding this comment.
Removed the no-op pass branch. run_id is now stored in the labels dict like the other keys.
goingforstudying-ctrl
force-pushed
the
fix/stackdriver-labels-from-path
branch
6 times, most recently
from
6ed66de to
a96dbdc
Compare
In Airflow 3 the supervisor process runs REMOTE_TASK_LOG handlers, but record.task_instance is never set in supervisor context (it is a task-subprocess concept). When task_instance is missing the proc() closure shipped log entries with empty labels, making Cloud Logging entries unsearchable by dag_id / task_id. Parse dag_id, task_id, and try_number from the structured AF3 log path (dag_id=<x>/run_id=<x>/task_id=<x>/attempt=<N>.log) instead. This requires zero DB access and works regardless of whether the handler runs in a task subprocess or the supervisor. relates to apache#68240
- Rename _labels_from_path to _extract_labels_from_path - Use path labels as fallback instead of overriding event-derived labels - Actually store run_id instead of no-op pass branch
goingforstudying-ctrl
force-pushed
the
fix/stackdriver-labels-from-path
branch
from
a96dbdc to
7869fd4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran into this while debugging a Cloud Logging setup on GKE — log entries were landing in Stackdriver with empty labels, making it impossible to filter by dag_id or task_id.
Turns out the StackdriverRemoteLogIO.processors proc() closure reads
record.task_instanceto populate labels, but in AF3's supervisor model the REMOTE_TASK_LOG handler runs in the supervisor process where that attribute is never set. So every log entry from the supervisor just gets empty labels.This grabs dag_id, task_id, and try_number from the log path instead. AF3's log path template is
dag_id=<x>/run_id=<x>/task_id=<x>/attempt=<N>.log— all four fields are already in the path with zero DB access needed.The fallback only kicks in when task_instance is genuinely missing, so the task-subprocess code path (where task_instance is available) is untouched.
Not sure if
run_idshould also be turned into a label here — left it out for now since the existing label set doesn't include it and the read-side filtering (bug 2) will need its own fix anyway. Happy to add it if maintainers think it belongs.relates to #68240