Log check_query_output response via format string in Snowflake SQL API hook#67848
Open
michaelneely wants to merge 3 commits into
Open
Log check_query_output response via format string in Snowflake SQL API hook#67848michaelneely wants to merge 3 commits into
michaelneely wants to merge 3 commits into
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide
|
1d32130 to
2f50c84
Compare
potiuk
approved these changes
Jun 6, 2026
potiuk
left a comment
Member
There was a problem hiding this comment.
LGTM — lazy %s formatting with the query id is a clear improvement over log.info(response_json), which eagerly stringified and dropped context. Test updated to match. Thanks!
Drafted-by: Claude Code (Opus 4.8); reviewed by @potiuk before posting
Author
|
Looks like azure provider tests are failing, but that has nothing to do with this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error:
SnowflakeSqlApiHook.check_query_outputlogs the raw response dict, which violatesStructuredLogMessage.event's str type.This prevents logs from being displayed in the UI after a deferred
SnowflakeSqlApiOperatorfinishes executing:Fix: Log the query response JSON in a templated string, matching the pattern used by other methods in the file.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.Important
🛠️ Maintainer triage note for @michaelneely · by
@potiuk· 2026-06-17 14:51 UTCHelpful heads-up from the maintainers — please address before this PR can be reviewed:
provider distributions tests / Compat 2.11.1:P3.10:,provider distributions tests / Compat 3.0.6:P3.10:,provider distributions tests / Compat 3.1.8:P3.10:,provider distributions tests / Compat 3.2.2:P3.10:. Reproduce and fix locally, then push.The ball is in your court — you've been assigned to this PR. Fix the above, then mark it Ready for review.
Automated triage — may be imperfect; a maintainer takes the next look.