Google Cloud Run: replace AirflowException with Python built-in exceptions#67769
Google Cloud Run: replace AirflowException with Python built-in exceptions#67769shahar1 wants to merge 1 commit into
Conversation
…tions AirflowException is pending deprecation. Replace all usages in providers/google/cloud/operators/cloud_run.py with the appropriate Python built-in exception types: - TimeoutError for operation timeouts - RuntimeError for all other error conditions Update the corresponding test assertions and remove the file from scripts/ci/prek/known_airflow_exceptions.txt since no AirflowException usages remain.
boring-cyborg
Bot
added
area:dev-tools
area:providers
backport-to-v3-2-test
shahar1
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl and
potiuk
as code owners
amoghrajesh
left a comment
amoghrajesh
left a comment
There was a problem hiding this comment.
This will be a breaking change for users upgrading to this version of google provider and whoever relied on the AirflowException raised for any custom behaviour will now break.
I don't know if we agreed regarding this on devlist but this should be a CHANGELOG entry as a "Breaking Change" as I see it (if we havent discussed on devlist, nows the time).
Requesting changes to avoid accidental merge
| missing_fields = [k for k in ["project_id", "region", "service_name"] if not getattr(self, k)] | ||
| if not self.project_id or not self.region or not self.service_name: | ||
| raise AirflowException( | ||
| raise RuntimeError( |
| missing_fields = [k for k in ["project_id", "region", "service_name"] if not getattr(self, k)] | ||
| if not self.project_id or not self.region or not self.service_name: | ||
| raise AirflowException( | ||
| raise RuntimeError( |
You've got a valid point - I assume that your main concerns are |
3 participants
Summary
AirflowExceptionis pending deprecation. Replace all usages inproviders/google/cloud/operators/cloud_run.pywith the appropriate Python built-in exception types:TimeoutErrorfor operation timeouts inexecute_completeRuntimeErrorfor all other error conditions throughout the fileUpdate test assertions to match and remove the file entry from
scripts/ci/prek/known_airflow_exceptions.txtsince noAirflowExceptionusages remain.This is a pure exception-type cleanup with no behaviour change. Spun out of #67767 to keep concerns separate.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (claude-sonnet-4-6) following the guidelines