Fix Task Instance mark-as downstream default#67763
Open
Codingaditya17 wants to merge 1 commit into
Open
Conversation
Codingaditya17
requested review from
bbovenzi,
choo121600,
guan404ming,
pierrejeambrun,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This PR updates the Task Instance mark-as dialog so that the
downstreamoption is no longer selected by default.Why
In the Task Instances view, marking a failed task instance as success should not automatically include downstream task instances unless the user explicitly selects that option.
Previously, the dialog defaulted to
downstream, which meant the request was sent withinclude_downstream: true. This could cause downstreamupstream_failedtask instances to be affected and resume within the same DagRun, which differs from the older Airflow 2 Task Instances view behavior.This change makes the action safer and more explicit: only the selected task instance is updated by default, while users can still choose downstream manually when they want that behavior.
How
downstreamselection fromMarkTaskInstanceAsDialogdownstreamis not selected by defaultTests
cd airflow-core/src/airflow/ui
pnpm test MarkTaskInstanceAsDialog.test.tsx
Result:
✓ src/components/MarkAs/TaskInstance/MarkTaskInstanceAsDialog.test.tsx (1 test) 123ms
✓ MarkTaskInstanceAsDialog (1)
✓ does not select downstream by default 120ms
Test Files 1 passed (1)
Tests 1 passed (1)
uv run prek run ts-compile-lint-ui --all-files
Result:
Running hooks for
airflow-core:Compile / format / lint UI...............................................Passed