Fix AMQP Object message decompression - #2256
Merged
Merged
Conversation
This fixes the AmqpMessageSupport utility to correctly decompress the body of Object Message's in all cases. Previously the decompression could stop early and not decompress the entire stream of data. This was due to the loop incorrectly casting the read int from the inflater stream as a byte before comparing to -1 to look for end of stream. This is incorrect because the read() method can return a value between -1 and 255. Java uses Two's Complement to represent signed ints, so if the returned value int is 255 and is cast to a byte it becomes -1. This meant that reading 255 would return -1 leading to the code to exit thinking end of stream has been reached.
cshannon
force-pushed
the
fix-amqp-object-decompression
branch
from
July 27, 2026 22:28
8470d34 to
ec2865b
Compare
9 tasks
tabish121
approved these changes
Jul 27, 2026
github-project-automation
Bot
moved this from Backlog
to Done
in Apache ActiveMQ v6.4.0
cshannon
added a commit
that referenced
this pull request
Jul 28, 2026
This fixes the AmqpMessageSupport utility to correctly decompress the body of Object Message's in all cases. Previously the decompression could stop early and not decompress the entire stream of data. This was due to the loop incorrectly casting the read int from the inflater stream as a byte before comparing to -1 to look for end of stream. This is incorrect because the read() method can return a value between -1 and 255. Java uses Two's Complement to represent signed ints, so if the returned value int is 255 and is cast to a byte it becomes -1. This meant that reading 255 would return -1 leading to the code to exit thinking end of stream has been reached. (cherry picked from commit 2d60a85)
cshannon
added a commit
that referenced
this pull request
Jul 29, 2026
This fixes the AmqpMessageSupport utility to correctly decompress the body of Object Message's in all cases. Previously the decompression could stop early and not decompress the entire stream of data. This was due to the loop incorrectly casting the read int from the inflater stream as a byte before comparing to -1 to look for end of stream. This is incorrect because the read() method can return a value between -1 and 255. Java uses Two's Complement to represent signed ints, so if the returned value int is 255 and is cast to a byte it becomes -1. This meant that reading 255 would return -1 leading to the code to exit thinking end of stream has been reached. (cherry picked from commit 2d60a85)
cshannon
added a commit
that referenced
this pull request
Jul 29, 2026
This fixes the AmqpMessageSupport utility to correctly decompress the body of Object Message's in all cases. Previously the decompression could stop early and not decompress the entire stream of data. This was due to the loop incorrectly casting the read int from the inflater stream as a byte before comparing to -1 to look for end of stream. This is incorrect because the read() method can return a value between -1 and 255. Java uses Two's Complement to represent signed ints, so if the returned value int is 255 and is cast to a byte it becomes -1. This meant that reading 255 would return -1 leading to the code to exit thinking end of stream has been reached. (cherry picked from commit 2d60a85)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes the AmqpMessageSupport utility to correctly decompress the body of Object Message's in all cases.
Previously the decompression could stop early and not decompress the entire stream of data. This was due to the loop incorrectly casting the read int from the inflater stream as a byte before comparing to -1 to look for end of stream.
This is incorrect because the read() method can return a value between -1 and 255. Java uses Two's Complement to represent signed ints, so if the returned value int is 255 and is cast to a byte it becomes -1. This meant that reading 255 would return -1 leading to the code to exit thinking end of stream has been reached.
This was discovered when I as was looking into the "flaky" test error for #2238,
JMSInteroperabilityTest.testOpenWireToQpidObjectMessageWithOpenWireCompression:493 » MessageFormat Failed to read object: nullTurns out, the test was not flaky but showed a real error. The test uses a random UUID, so by the test would intermittently fail depending on if the UUID decompression ran into a 255 int or not.