Skip to content

Remove redundant minimalMavenBuildVersion override#6467

Open
DomGarguilo wants to merge 1 commit into
apache:mainfrom
DomGarguilo:removeMavenMinOverride
Open

Remove redundant minimalMavenBuildVersion override#6467
DomGarguilo wants to merge 1 commit into
apache:mainfrom
DomGarguilo:removeMavenMinOverride

Conversation

@DomGarguilo

Copy link
Copy Markdown
Member

Remove the local minimalMavenBuildVersion property from the pom.

Apache parent pom version 36 added the same Maven 3.9 minimum via a PR I made at apache/maven-apache-parent#533. We use version 37 which includes this so the override is now redundant and we can remove it.

Refs:

@DomGarguilo DomGarguilo added this to the 4.0.0 milestone Jul 8, 2026
@DomGarguilo DomGarguilo self-assigned this Jul 8, 2026
@DomGarguilo

Copy link
Copy Markdown
Member Author

Verified the effective POM shows the expected 3.9 after removing the local override:

mvn help:effective-pom -Doutput=/tmp/accumulo-effective-pom.xml -DskipTests
grep -n "minimalMavenBuildVersion" /tmp/accumulo-effective-pom.xml

@ctubbsii ctubbsii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine, but should be applied to 2.1 first and merged to main. I try to keep the build stuff up-to-date on all our active branches, because it helps ensure a smooth release, rather than just apply this stuff to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants