Adding new Mutation constructor with ByteSequence parameter to remove 1 TODO#6463
Open
Amemeda wants to merge 4 commits into
Open
Adding new Mutation constructor with ByteSequence parameter to remove 1 TODO#6463Amemeda wants to merge 4 commits into
Amemeda wants to merge 4 commits into
Conversation
Contributor
Author
|
Removes 1 TODO from #2699 |
dlmarion
reviewed
Jul 9, 2026
|
|
||
| public ConditionalMutation(ByteSequence row, Condition... conditions) { | ||
| // TODO add ByteSequence methods to mutations | ||
| super(row.toArray()); |
Contributor
There was a problem hiding this comment.
I'm assuming the new constructor would be called here too. I'm curious how many places in the code would take advantage of the new constructor for the amount of code that it adds to Mutation. If there are not many places, then I think it might be better to just remove the TODO.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing
TODO add ByteSequence methods to mutationsfrom line 63 of ConditionalMutation.javaUpdated Mutation.java
Updated MutationTest.java