Skip to content

Removing CustomThreadedSelectorServer.java#6454

Open
Amemeda wants to merge 5 commits into
apache:mainfrom
Amemeda:cleanup
Open

Removing CustomThreadedSelectorServer.java#6454
Amemeda wants to merge 5 commits into
apache:mainfrom
Amemeda:cleanup

Conversation

@Amemeda

@Amemeda Amemeda commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Investigated relevance of CustomThreadedSelectorServer.java

  • This file overrides getRunnable method from TThreadedSelectorServer.java.
  • CustomThreadedSelectorServer.java had only 1 usage in TServerUtils.java: return new ServerAddress(new CustomThreadedSelectorServer(options), address);

Result:

  • Deleted file CustomThreadedSelectorServer.java
  • replaced its 1 usage with TThreadedSelectorServer.java
  • Added file ThriftServerEventHandler.java
  • in TServerUtils.java, implementing method setServerEventHandler(new ThriftServerEventHandler()); to applicable tservers

@Amemeda Amemeda marked this pull request as ready for review June 30, 2026 16:03
@Amemeda

Amemeda commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

@ctubbsii

@DomGarguilo DomGarguilo added this to the 4.0.0 milestone Jun 30, 2026
@DomGarguilo DomGarguilo requested a review from ctubbsii June 30, 2026 21:04
@Amemeda Amemeda requested a review from dlmarion July 8, 2026 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants