Cancel server work when clients disconnect - #707
Open
mcollina wants to merge 1 commit into
Open
Conversation
Author
|
Most harness have short timeouts and quick retries. This change avoid that a busy queue become a self-dos. |
mcollina
force-pushed
the
server-client-disconnect-cancellation
branch
from
August 5, 2026 20:51
eea7924 to
e9ded97
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A graceful peer FIN, including a write-side half-close, is intentionally treated as request cancellation for this one-request HTTP/1.1 server.
Validation
make -j2 ds4_test ds4-server ds4_server_cpu.o./ds4_test --servergit diff --checkA live model disconnect smoke test was not run; the existing server process was left running.