server: preserve reasoning_content token boundaries - #692
Draft
rareba wants to merge 1 commit into
Draft
Conversation
|
Nice diagnosis and fix. Since your diff is scoped to the OpenAI path, opened #712 to apply the exact same |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The thinking stream held a fixed seven-byte suffix to detect a possibly split
closing think marker. Every update therefore emitted the current decoded token
minus seven bytes, then emitted that tail with the next token.
Remembering the previous decoded-token end preserves whole-token deltas while
keeping the close-tag and UTF-8 safeguards intact. The only cost is one token
of reasoning-stream latency.
Impact
Clients that process individual reasoning deltas now receive stable token
units instead of character fragments. Reassembled output is unchanged.
Validation
Windows 11 host, WSL Linux CPU/reference build; no model required:
Closes #685