Fix server JSON duplicate-field cleanup#433
Open
539hex wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes request parser cleanup for malformed duplicate JSON fields.
Several server JSON parsers replaced owned string/raw-value fields by freeing the
previous value before parsing the replacement. If a request repeated one of those
fields and the second value was malformed, the parser jumped to its cleanup path
while the pointer still referenced freed memory. The cleanup path could then free
the same pointer again.
This changes owned-field replacement to parse into a temporary value first, then
free/swap only after parsing succeeds.
Details
json_*_replace()helpers for ownedchar *parser fields.Responses, and tool-schema request parsing.
goto badcleanup style, andrequest behavior.
Validation
Machine/backend/model:
ds4flash.gguf/ DeepSeek V4 Flash local symlinkCommands run:
Runtime regression check:
Then, from another shell:
Before the fix, this closed the connection without a response and the server
aborted with a malloc error:
After the fix, it returns:
HTTP/1.1 400 Bad RequestA follow-up health check confirms the server stays alive:
Result:
HTTP/1.1 200 OKThis PR only claims the demonstrated remote malformed-request crash / memory-safety issue, and does not make broader exploitability claims.